Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring informer resync time #1216

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Allow configuring informer resync time #1216

merged 2 commits into from
Oct 2, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Oct 2, 2024

This PR:

  • Changes the behavior of the informer synchronization timeout, which might be high in large clusters. Instead of disabling kubernetes decoration, shows a warning and starts decoration while the metadata is still updated in the background.
  • Makes the informer resync time configurable, and increases its default value to 30 minutes. Higher values will cause less load in the Kube API.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.72%. Comparing base (4c93dcd) to head (60e0c63).

Files with missing lines Patch % Lines
pkg/internal/kube/informer.go 66.66% 3 Missing ⚠️
pkg/internal/kube/informer_provider.go 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1216      +/-   ##
==========================================
+ Coverage   81.70%   81.72%   +0.01%     
==========================================
  Files         137      137              
  Lines       11475    11483       +8     
==========================================
+ Hits         9376     9384       +8     
  Misses       1560     1560              
  Partials      539      539
Flag Coverage Δ
integration-test 60.73% <45.45%> (-0.01%) ⬇️
k8s-integration-test 58.28% <75.75%> (+0.02%) ⬆️
oats-test 36.08% <45.45%> (-0.01%) ⬇️
unittests 53.03% <72.72%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit c6c0aa1 into grafana:main Oct 2, 2024
12 checks passed
@mariomac mariomac deleted the cfg-resync branch October 2, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marctc marctc marctc approved these changes

@grcevski grcevski Awaiting requested review from grcevski grcevski is a code owner

@rafaelroquetto rafaelroquetto Awaiting requested review from rafaelroquetto rafaelroquetto is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariomac @codecov-commenter @marctc